Hi folks,
On 5/26/20 8:15 PM, Gerald Pfeifer wrote:
Okay to backport c00568f376078129196740d83946d54dc5437401 to the GCC 9
branch, Jakub?
I don't see it yet on 9, so if 9 is still open for pushes I'd like too to
see that commit applied to 9 (it should apply cleanly). For the records,
the commit message changed a bit just before the push, so pasting below how
it looks now (Gerald previously posted the correct hash, but the message was
not updated). Gerald, thanks a lot for tracking it.
commit c00568f376078129196740d83946d54dc5437401
Author: Gustavo Romero <grom...@linux.ibm.com>
Date: Wed Apr 15 15:14:45 2020 +0200
selftest: Work around GCC 4.2 PR33916 bug by optimizing the ctor [PR89494]
GCC 4.2 due to PR33916 miscompiles temp_dump_context ctor, because it doesn't
zero initialize the whole dump_context temporary on which it runs the static
get method and during destruction of the temporary an uninitialized pointer
is deleted.
More recent GCC versions properly zero initialize it and ideally optimize away
the construction/destruction of the temporary, as it isn't used for
anything,
but there is no reason to create the temporary, static member functions can
be called without an associated object.
2020-04-15 Gustavo Romero <grom...@linux.ibm.com>
PR bootstrap/89494
* dumpfile.c (selftest::temp_dump_context::temp_dump_context):
Don't construct a dump_context temporary to call static method.
Please let me know if any action from my side is necessary, like testing.
Thanks and best regards,
Gustavo
