Nick Clifton <ni...@redhat.com> writes: > Hi Nick, Hi Ian, >>> In file included from gold/archive.cc:29: >>> include/libiberty.h:646:25: error: 'register' storage class >>> specifier is deprecated and incompatible with C++17 >>> [-Werror,-Wdeprecated-register] >>> >>> So I would like to apply the patch below to fix this. Is this OK ? >> >> Yes please! This was copied straight from bsearch.c, so you probably >> want to change bsearch.c and bsearch_r.c as well (just in case clang >> ever finds itself needing to build bsearch_r out of libiberty). > > OK, here is a revised patch. Ian - is this OK ? > > Cheers > Nick > > include/ChangeLog > 2020-06-25 Nick Clifton <ni...@redhat.com> > > * libiberty.h (bsearch_r): Remove use of the register keyword from > the prototype. > > libiberty/ChangeLog > 2020-06-25 Nick Clifton <ni...@redhat.com> > > * bsearch.c (bsearch): Remove use of register keyword. > * bsearch_r.c (bsearch_r): Likewise.
Sure, this is fine. Thanks. Ian
