On Jun 2, 2020, at 10:37 PM, Frederik Harwath <frede...@codesourcery.com> wrote: > > Frederik Harwath <frede...@codesourcery.com> writes: > > ping :-)
Ok. >> Frederik Harwath <frede...@codesourcery.com> writes: >> >> Hi Rainer, hi Mike, >> ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545803.html >> >> Best regards, >> Frederik >> >>> Hi Thomas, >>> >>> Thomas Schwinge <tho...@codesourcery.com> writes: >>> >>>> I can't formally approve testsuite patches, but did a review anyway: >>> >>> Thanks for the review! >>> >>>> On 2020-05-15T12:31:54+0200, Frederik Harwath <frede...@codesourcery.com> >>>> wrote: >>> >>>>> The dump >>>>> scanning procedures are changed to make the test unresolved >>>>> if globbing matches more than one file. >>>> >>>> (The code changes look good, but I have not tested that specific aspect.) >>> >>> We do not have automated tests for the testsuite commands :-), but I >>> have of course tested this manually. >>> >>>> As I said, not an approval, and minor comments (see below), but still: >>>> >>>> Reviewed-by: Thomas Schwinge <tho...@codesourcery.com> >>>> >>>> Do we have to similarly also audit/alter other testsuite infrastructure >>>> files, anything that uses '[glob [...]]'? (..., and then generalize >>>> 'glob-dump-file' into 'glob-one-file', or similar.) That can be done >>>> incrementally, as far as I'm concerned. >>> >>> I also think it would make sense to adapt similar test commands as well. >>> >>>> May also make this more useful/explicit: >>>> >>>> This is useful if, for example, if a pass has several static >>>> instances [correct terminology?], and depending on torture testing >>>> command-line flags, a different instance executes and produces a dump >>>> file, and so in the test case you can use a generic [put example >>>> here] to scan the varying dump files names. >>>> >>>> (Or similar.) >>> >>> I have moved the explanation below the description of the individual >>> commands and added an example. See the attached revised patch. >>> >>> Best regards, >>> Frederik >>> >>> From 2a17749d6dbcac690d698323240438722d6119ef Mon Sep 17 00:00:00 2001 >>> From: Frederik Harwath <frede...@codesourcery.com> >>> Date: Fri, 15 May 2020 10:35:48 +0200 >>> Subject: [PATCH] testsuite: clarify scan-dump file globbing behavior >>> >>> The test commands for scanning optimization dump files >>> perform globbing on the argument that specifies the suffix >>> of the dump files to be scanned. This behavior is currently >>> undocumented. Furthermore, the current implementation of >>> "scan-dump" and similar procedures yields an error whenever >>> the file name globbing matches more than one file (due to an >>> attempt to call "open" on multiple files) while a failure to >>> match any file results in an unresolved test. >>> >>> This commit documents the globbing behavior. The dump >>> scanning procedures are changed to make the test unresolved >>> if globbing matches more than one file. >>> >>> gcc/ChangeLog: >>> >>> 2020-05-19 Frederik Harwath <frede...@codesourcery.com> >>> >>> * doc/sourcebuild.texi: Describe globbing of the >>> dump file scanning commands "suffix" argument. >>> >>> gcc/testsuite/ChangeLog: >>> >>> 2020-05-19 Frederik Harwath <frede...@codesourcery.com> >>> >>> * lib/scandump.exp (glob-dump-file): New proc. >>> (scan-dump): Use glob-dump-file for file name expansion. >>> (scan-dump-times): Likewise. >>> (scan-dump-dem): Likewise. >>> (scan-dump-dem-not): Likewise.
