There is some concern about clang's -fuse-ld=path http://lists.llvm.org/pipermail/cfe-dev/2020-June/065710.html and use of COMPILER_PATH vs PATH. Shall we introduce another option like -fld-path=path (PATH is used, COMPILER_PATH is not used)?
On Tue, Jun 30, 2020 at 6:04 AM Martin Liška <mli...@suse.cz> wrote: > > PING^1 > > On 5/29/20 3:10 AM, Fangrui Song wrote: > > On 2020-05-25, Martin Liška wrote: > >> On 5/22/20 6:42 AM, Fangrui Song wrote: > >>> but I can't fix this one because joining two lines will break the > >>> 80-column rule. > >> > >> What about this: > >> > >> diff --git a/gcc/collect2.c b/gcc/collect2.c > >> index cc57a20e08b..e5b54b080f7 100644 > >> --- a/gcc/collect2.c > >> +++ b/gcc/collect2.c > >> @@ -1138,8 +1138,8 @@ main (int argc, char **argv) > >> /* Search the ordinary system bin directories > >> for `ld' (if native linking) or `TARGET-ld' (if cross). */ > >> if (ld_file_name == 0) > >> - ld_file_name = > >> - find_a_file (&path, full_ld_suffixes[selected_linker], X_OK); > >> + ld_file_name > >> + = find_a_file (&path, full_ld_suffixes[selected_linker], X_OK); > >> } > >> #ifdef REAL_NM_FILE_NAME > >> > >> Apart from that, the patch is fine. > >> > >> Martin > > > > Adding people who may be able to approve and commit on my behalf. > > > > This formatting issue seems small enough. Hopefully a maintainer can do > > it for me. > -- 宋方睿