> -----Original Message----- > From: Szabolcs Nagy <szabolcs.n...@arm.com> > Sent: 08 July 2020 16:48 > To: Kyrylo Tkachov <kyrylo.tkac...@arm.com> > Cc: gcc-patches@gcc.gnu.org; fwei...@redhat.com; Richard Earnshaw > <richard.earns...@arm.com>; Daniel Kiss <daniel.k...@arm.com> > Subject: Re: [PATCH 2/4] aarch64: fix __builtin_eh_return with pac-ret > [PR94891] > > The 07/08/2020 13:24, Kyrylo Tkachov wrote: > > Hi Szabolcs, > > > The 06/05/2020 17:51, Szabolcs Nagy wrote: > > > > --- a/gcc/config/aarch64/aarch64.c > > > > +++ b/gcc/config/aarch64/aarch64.c > > > > @@ -6954,6 +6954,10 @@ aarch64_return_address_signing_enabled > (void) > > > > /* This function should only be called after frame laid out. */ > > > > gcc_assert (cfun->machine->frame.laid_out); > > > > > > > > + /* TODO: Big hammer handling of __builtin_eh_return. */ > > > > ... I don't think this comment is very useful. Please make it a bit more > descriptive. If you want to leave the TODO here, please give a more concrete > action plan. > > see attached patch with more detailed comment and commit message.
Nice, thanks. Kyrill
