On 7/9/20 12:11 PM, Segher Boessenkool wrote:
>> gcc/testsuite/
>> PR target/96125
>> * gcc.target/powerpc/pr96125.c: New test.
>
> Okay for trunk and 10 (but see test nit below). Thanks!
[snip]
> So maybe we should just do all builtins always?
I think that is the correct thing to do, but I think maybe that
should wait for Bill's rewrite of the built-in generation.
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/powerpc/pr96125.c
>> @@ -0,0 +1,47 @@
>> +/* { dg-do compile } */
>> +/* { dg-require-effective-target powerpc_vsx_ok } */
>> +/* { dg-options "-mdejagnu-cpu=power8 -O2" } */
>
> powerpc_vsx_ok is not the right test for -mcpu=power8 (it means p7).
> Usually powerpc_p8vector_ok is used... not a great situation, but :-)
As we discussed offline, I changed this to -mdejagnu-cpu=power7 and
kept the powerpc_vsx_ok effective target test, so that this test case
will get more coverage, especially on older power7 BE systems.
I verified the updated test case passes on both LE and BE, so I've
pushed this now. I'll let Bill Seurer's nightly testing try this
on a wider variety of builds before backporting this to GCC10.
I'll try and do that tomorrow.
Thanks!!
Peter
