On 2020-07-16 6:37 p.m., Aaron Merey wrote: > On Fri, May 8, 2020 at 4:56 PM Tom Tromey <t...@tromey.com> wrote: >> >>>>>>> "Aaron" == Aaron Merey via Binutils <binut...@sourceware.org> writes: >> >> Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. >> Aaron> * aclocal.m4: Rebuild. >> >> Instead of inlining pkg.m4 into aclocal.m4, how about making >> config/pkg.m4 and then using m4_include from gdb/acinclude.m4? >> That's what gdb does for other shared m4 code. > > Resending the patch for this since my last attempt didn't seem to > properly reply to > Tom's email. >
Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? Otherwise, from GDB's point of view I think it looks good, unless Tom has some things to add. Simon