Now moved to libgomp, cf. attachment.
Tobias
On 7/22/20 11:16 AM, Jakub Jelinek wrote:
On Wed, Jul 22, 2020 at 11:09:06AM +0200, Thomas Schwinge wrote:
So I suppose you'll either have to put these testcases into 'libgomp', or
we'll have to invent something else?
Indeed.
Jakub, is there a reason why for
build-tree testing we can't just add '-I[build-tree]/libgomp' etc. in
'gcc.dg/gomp/gomp.exp' etc.?
I guess historic reasons. E.g. g++.dg/ adds those and -L for libstdc++ too,
but then most of the C++ tests that test primarily the compiler and
sometimes use headers and even more often the runtime library are there.
On the gomp side, libgomp/testsuite has been used for both compile and
link/runtime tests that need the runtime library and its headers, while
gcc/testsuite/*/gomp/ has been left for tests that don't need any of those.
Jakub
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
commit ade6e7204ce4d179cd9fa4637ddee85ba1fa12d9
Author: Tobias Burnus <tob...@codesourcery.com>
Date: Wed Jul 22 12:12:48 2020 +0200
critical-hint-*.{c,f90}: Move from gcc/testsuite to libgomp/testsuite
libgomp/ChangeLog:
* testsuite/libgomp.c-c++-common/critical-hint-1.c: New; moved from
gcc/testsuite/c-c++-common/gomp/.
* testsuite/libgomp.c-c++-common/critical-hint-2.c: Likewise.
* testsuite/libgomp.fortran/critical-hint-1.f90: New; moved
from gcc/testsuite/gfortran.dg/gomp/.
* testsuite/libgomp.fortran/critical-hint-2.f90: Likewise.
gcc/testsuite/ChangeLog:
* c-c++-common/gomp/critical-hint-1.c: Moved to libgomp/.
* c-c++-common/gomp/critical-hint-2.c: Moved to libgomp/.
* gfortran.dg/gomp/critical-hint-1.f90: Moved to libgomp/.
* gfortran.dg/gomp/critical-hint-2.f90: Moved to libgomp/.
---
.../gomp => libgomp/testsuite/libgomp.c-c++-common}/critical-hint-1.c | 2 ++
.../gomp => libgomp/testsuite/libgomp.c-c++-common}/critical-hint-2.c | 1 +
.../gomp => libgomp/testsuite/libgomp.fortran}/critical-hint-1.f90 | 2 ++
.../gomp => libgomp/testsuite/libgomp.fortran}/critical-hint-2.f90 | 1 +
4 files changed, 6 insertions(+)
diff --git a/gcc/testsuite/c-c++-common/gomp/critical-hint-1.c b/libgomp/testsuite/libgomp.c-c++-common/critical-hint-1.c
similarity index 98%
rename from gcc/testsuite/c-c++-common/gomp/critical-hint-1.c
rename to libgomp/testsuite/libgomp.c-c++-common/critical-hint-1.c
index 510f8abef80..1e49747477b 100644
--- a/gcc/testsuite/c-c++-common/gomp/critical-hint-1.c
+++ b/libgomp/testsuite/libgomp.c-c++-common/critical-hint-1.c
@@ -1,3 +1,5 @@
+/* { dg-do compile } */
+
#include <omp.h>
void
diff --git a/gcc/testsuite/c-c++-common/gomp/critical-hint-2.c b/libgomp/testsuite/libgomp.c-c++-common/critical-hint-2.c
similarity index 98%
rename from gcc/testsuite/c-c++-common/gomp/critical-hint-2.c
rename to libgomp/testsuite/libgomp.c-c++-common/critical-hint-2.c
index effe24a63ec..057353b6ce2 100644
--- a/gcc/testsuite/c-c++-common/gomp/critical-hint-2.c
+++ b/libgomp/testsuite/libgomp.c-c++-common/critical-hint-2.c
@@ -1,3 +1,4 @@
+/* { dg-do compile } */
/* { dg-additional-options "-fdump-tree-original" } */
#include <omp.h>
diff --git a/gcc/testsuite/gfortran.dg/gomp/critical-hint-1.f90 b/libgomp/testsuite/libgomp.fortran/critical-hint-1.f90
similarity index 99%
rename from gcc/testsuite/gfortran.dg/gomp/critical-hint-1.f90
rename to libgomp/testsuite/libgomp.fortran/critical-hint-1.f90
index c26b617f1bd..225d9a7a221 100644
--- a/gcc/testsuite/gfortran.dg/gomp/critical-hint-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/critical-hint-1.f90
@@ -1,3 +1,5 @@
+! { dg-do compile }
+
subroutine example_criticial ()
use omp_lib
implicit none
diff --git a/gcc/testsuite/gfortran.dg/gomp/critical-hint-2.f90 b/libgomp/testsuite/libgomp.fortran/critical-hint-2.f90
similarity index 99%
rename from gcc/testsuite/gfortran.dg/gomp/critical-hint-2.f90
rename to libgomp/testsuite/libgomp.fortran/critical-hint-2.f90
index 15d6206a438..f34680ca718 100644
--- a/gcc/testsuite/gfortran.dg/gomp/critical-hint-2.f90
+++ b/libgomp/testsuite/libgomp.fortran/critical-hint-2.f90
@@ -1,3 +1,4 @@
+! { dg-do compile }
! { dg-additional-options "-fdump-tree-original" }
subroutine example_criticial ()
use omp_lib
