On Thu, Jul 23, 2020 at 08:15:42PM -0500, Peter Bergner wrote:
> We get an ICE when using -mpower10 and a -mcpu= value that is older
> than power10.  The -mpower10 option requires -mcpu=power10 or later.
> The following patch enforces that.

Hi!

> +  /* If the user explicitly uses -mpower10, ensure our ISA flags are
> +     compatible with it.  */
> +  if (TARGET_POWER10
> +      && (rs6000_isa_flags_explicit & OPTION_MASK_POWER10) != 0
> +      && (processor_target_table[cpu_index].target_enable
> +       & OPTION_MASK_POWER10) == 0)
> +    error ("%qs requires %qs", "-mpower10", "-mcpu=power10");

This still allows -mpower10 without corresponding -mcpu=.  We should
just remove this command like flag (but keep the internal flag); for
power10 we can do that without any issues, it is new (some testcases
will need fixing, but it is that: fixing).


Segher

Reply via email to