On 06/08/20 08:57 +0200, Richard Biener wrote:
On Thu, Aug 6, 2020 at 3:07 AM Andrew MacLeod <amacl...@redhat.com> wrote:
On 8/5/20 12:54 PM, Richard Biener via Gcc-patches wrote:
> On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor <mjam...@suse.cz> wrote:
>> On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote:
>> [...]
>>
>>> * ipa-cp changes from vec<value_range> to std::vec<value_range>.
>>>
>>> We are using std::vec to ensure constructors are run, which they
>> aren't
>>> in our internal vec<> implementation. Although we usually steer away
>>> from using std::vec because of interactions with our GC system,
>>> ipcp_param_lattices is only live within the pass and allocated with
>> calloc.
>> Ummm... I did not object but I will save the URL of this message in the
>> archive so that I can waive it in front of anyone complaining why I
>> don't use our internal vec's in IPA data structures.
>>
>> But it actually raises a broader question: was this supposed to be an
>> exception, allowed only not to complicate the irange patch further, or
>> will this be generally accepted thing to do when someone wants to have
>> a
>> vector of constructed items?
> It's definitely not what we want. You have to find another solution to this
problem.
>
> Richard.
>
Why isn't it what we want?
This is a small vector local to the pass so it doesn't interfere with
our PITA GTY.
The class is pretty straightforward, but we do need a constructor to
initialize the pointer and the max-size field. There is no allocation
done per element, so a small number of elements have a couple of fields
initialized per element. We'd have to loop to do that anyway.
GCC's vec<> does not provide he ability to run a constructor, std::vec
does.
Other places in the compiler use placement new here. The only
complication is re-allocation which would require move CTORs which
up to a few weeks ago were not available. But of course we want
our own re-allocation policy, thus vec<>, not std::vector.
Also you do
#include <vector>
inside ipa-fnsummary.c - you should know better to not include
system headers from .c files - they need to go in system.h.
You should do a
#define INCLUDE_VECTOR
before the system.h include in ipa-fnsummary.c instead.
I find it only mildly amusing that review & approval of this happened
behind the scenes ...
I scanned the code but didn't spot the point where you'd need to run
CTORs? Can you point me to that?
I quizzed some libstdc++ folks, and there has been a lot of
optimizations done on std::vec over the last few years,.. They think its
pretty good now, and we were encouraged to use it.
We can visit the question tho... What is the rationale for not using
std::vec in the compiler? We currently use std::swap, std:pair,
std::map, std::sort, and a few others.
We're using std::swap and std::pair throughoug because those are lean.
One of the main motivations to not use the STL is because of TU
explosion when including lots of those large headers. Bootstrap times
are still an issue.
There's also code size issues when we have both std::vector<tree>
and vec<tree> instantiations. And as you say vec<> isn't going away
because there's no way to make std::vector & friends GC aware.
Then there's consistency across the code-base. A big mess will
scare of new contributors.
So do weird types that don't run constructors and require manually
constructing things into buffers with placement new, or only using
types with trivial default construcrors. It's not 1994.
Containers should own and manage their contents. Maybe adding support
for non-trivial construction to vec and making it movable (and not
copyable) would make it more useful.
Oh, and existing uses are mostly mistakes and are _not_ a reason
to add more "exceptions" - instead they are a reason to rectify those
mistakes.
Richard.
is there some aspect of using std::vec I am not aware of that makes it
something we need to avoid?
Andrew
