xiezhiheng <xiezhih...@huawei.com> writes: >> -----Original Message----- >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> Sent: Tuesday, August 25, 2020 7:08 PM >> To: xiezhiheng <xiezhih...@huawei.com> >> Cc: Richard Biener <richard.guent...@gmail.com>; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> emitted at -O3 >> >> xiezhiheng <xiezhih...@huawei.com> writes: >> >> -----Original Message----- >> >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> >> Sent: Friday, August 21, 2020 5:02 PM >> >> To: xiezhiheng <xiezhih...@huawei.com> >> >> Cc: Richard Biener <richard.guent...@gmail.com>; >> gcc-patches@gcc.gnu.org >> >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> >> emitted at -O3 >> > >> > Cut... >> > >> >> Looks like the saturating intrinsics might need a bit more thought. >> >> Would you mind submitting the patch with just the other parts? >> >> Those were uncontroversial and it would be a shame to hold them >> >> up over this. >> > >> > Okay, I reorganized the existing patch and finished the first half of the >> intrinsics >> > except saturating intrinsics and load intrinsics. >> > >> > Bootstrapped and tested on aarch64 Linux platform. >> >> I know this'll be frustrating, sorry, but could you post the >> 2020-08-17 patch without the saturation changes? It's going to be >> easier to track and review if each patch deals with similar intrinsics. >> The non-saturating part of the 2020-08-17 patch was good because it was >> dealing purely with arithmetic operations. Loads should really be a >> separate change. >> >> BTW, for something like this, it's OK to test and submit several patches >> at once, so separating the patches doesn't need to mean longer test cycles. >> It's just that for review purposes, it's easier if one patch does one thing. >> > > That's true. And I finished the patch to add FLAG for add/sub arithmetic > intrinsics except saturating intrinsics. Later I will try to separate the > rest > into several subsets to fix. > > Bootstrapped and tested on aarch64 Linux platform.
Thanks, looks great. Pushed to master. Richard
