Hi!
On Thu, Aug 27, 2020 at 08:47:19PM +0800, Jojo R wrote:
> +insn-emit-split-c = $(foreach o, $(shell for i in
> {1..$(insn-generated-split-num)}; do echo $$i; done), insn-emit$(o).c)
If you use a variable for the result of that "seq", this will be more
readable / maintainable / etc.
(Should this use := instead of = ? What about the assignment to
insn-generated-split-num itself?)
> + long long read_count = 0;
We use "int" in many other places for similar counts. 2**31 should be
enough for anybody.
> md_rtx_info info;
> while (read_md_rtx (&info))
> + {
> + if (!(read_count++ % 10000))
Wrong indent. "== 0" is more typical for testing if numbers are zero.
> + {
> + printf ("/* Split file into separate compilation units for parallel
> compilation %lld */\n\n", read_count);
Please split this (at least the source line, but probably the target
line is too long a well).
All that are details. This does look like it fixes the problems in the
previous versions. Thanks!
Segher
