Hi! On Tue, Sep 01, 2020 at 11:19:55AM +0800, Kewen.Lin wrote: > This is a trivial patch to clean existing rs6000 test targets > p8 and p9+ with existing has_arch_pwr8 and has_arch_pwr9 > target combination or only one of them. Not sure if it's a > good idea to tidy this, but send out for comments.
The has_arch_xxx is a lot easier to understand. The "p9+" thing would become especially un-nice if there was an actual processor called "Power9+" (there were for p4, p5, p7 at least, so it is a practical concern). > * gcc.target/powerpc/pr92398.p9+.c: Replace p9+ with has_arch_pwr9. > * gcc.target/powerpc/pr92398.p9-.c: Replace p9+ with has_arch_pwr9, > and replace p8 with has_arch_pwr8 && !has_arch_pwr9. > * lib/target-supports.exp (check_effective_target_p8): Remove. > (check_effective_target_p9+): Remove. > +/* { dg-final { scan-assembler-times {\mstd\M} 2 { xfail { { {! > has_arch_pwr9} && has_arch_pwr8 } && be } } } } */ Not sure you need all braces here. But this isn't pure tcl, some of it is parsed by routines in dejagnu (which allow much less), so who knows. Okay for trunk. Thanks! Segher