On Wed, Aug 26, 2020 at 10:44:22PM -0400, Michael Meissner wrote: > PowerPC: Rename functions for min, max, cmove. > > This patch renames the functions that generate the ISA 3.0 C minimum, C > maximum, and conditional move instructions to use a better name than just > using > a _p9 suffix. Because the functions can fail, the names use "maybe_emit" > instead of "generate_" in the name.
Please keep the rs6000_ prefix though. If we want to drop that, we should do it *everywhere*. > -/* ISA 3.0 (power9) minmax subcase to emit a XSMAXCDP or XSMINCDP instruction > - for SF/DF scalars. Move TRUE_COND to DEST if OP of the operands of the > last > - comparison is nonzero/true, FALSE_COND if it is zero/false. Return 0 if > the > - hardware has no such operation. */ > +/* Possibly emit the C variant of the minimum or maximum instruction for > + floating point scalars (xsmincdp, xsmaxcdp, etc.). Please explain that this is asymmetric. This isn't a proper min/max, except with fastmath :-( > + /* See if we can use the "C" minimum, "C" maximum, and compare and set mask > + instructions. */ Just write the actual mnemonics please. Okay for trunk with those things fixed. Thanks! Segher
