On Thu, 1 Oct 2020, Tom de Vries wrote:
> [ was: Re: [committed][testsuite] Re-enable pr94600-{1,3}.c tests for arm ]
>
> On 10/1/20 7:38 AM, Hans-Peter Nilsson wrote:
> > On Wed, 30 Sep 2020, Tom de Vries wrote:
> >> I've analyzed the compilation on strict-alignment target arm-eabi, and
> >
> > An analysis should result in more than that statement.
> >
>
> Well, it refers to the analysis in the commit log of the patch, sorry if
> that was not obvious.
Aha, I think I only saw your first commit, thanks. Yes, that
looked more appropriate, but I would have preferred a proper
review to a commit-as-obvious (assuming that was the track when
nothing else was stated), since this was more than just target
gating or *trivial* missing predicates.
> Thanks for the pointer to pr94600-2.c. I've compared the behaviour
> between pr94600-1.c and pr94600-2.c and figured out why in one case we
> get the load/store pair, and in the other the memcpy. See rationale in
> commit below.
You may be on the right track judging from the commit log, and I
see my hunch about MOVE_RATIO wasn't far off either. I guess I
should look into it too with rested eyes, but I'm happy with
this direction; not disabling the test for many targets.
Thanks for looking into it again.
brgds, H-P
