On Fri, 2 Oct 2020, Tobias Burnus wrote:
> However, this flag can be added into the offload-target's libgomp.spec,
> which avoids all kind of issues. That's what this patch now does.
>
> I tested it with x86_64-gnu-linux w/o + w/ nvptx-none. Result:
> * x86_64-gnu-linux's libgomp.spec:
> "*link_gomp: -lgomp %{static: -ldl } --as-needed -latomic --no-as-needed"
> * nvptx-none's libgomp.spec:
> "*link_gomp: -lgomp -latomic"
>
> On x86-64, a simple test program did not use and also did not link libatomic.
>
> OK?
Do all testsuites that link using libgomp.spec also use the testsuite
logic from atomic-dg.exp to locate libatomic for build-tree testing
(otherwise -latomic will fail if it can't be found and there isn't an
installed system copy that the driver might fall back on, even with
--as-needed)?
My view as noted in bug 81358 is that --as-needed -latomic --no-as-needed
should *always* be used (given --as-needed supported and libatomic built),
not restricted to when libgomp is needed. But while adding it only for
libgomp might make a useful improvement while reducing the extent to which
global testsuite / configure test changes need to be made at the same
time, some testsuite support should still be needed if not already in use.
--
Joseph S. Myers
jos...@codesourcery.com
