Hi!
On Sun, Oct 04, 2020 at 11:09:11PM +1030, Alan Modra wrote:
> On Fri, Oct 02, 2020 at 01:50:24PM -0500, Segher Boessenkool wrote:
> > > + /* If reg parm stack space increases, we cannot sibcall. */
> > > + if (REG_PARM_STACK_SPACE (decl ? decl : fntype)
> > > + > REG_PARM_STACK_SPACE (current_function_decl))
> > > + {
> > > + maybe_complain_about_tail_call (exp,
> > > + "inconsistent size of stack space"
> > > + " allocated for arguments which are"
> > > + " passed in registers");
> > > + return false;
> > > + }
> >
> > Maybe change the message? You allow all sizes smaller or equal than
> > the current size, "inconsistent" isn't very great for that.
>
> We're talking about just two sizes here. For 64-bit ELFv2 the reg
> parm save size is either 0 or 64 bytes. Yes, a better message would
> be "caller lacks stack space allocated for aguments passed in
> registers, required by callee".
Something like that yes. However:
> Note that I'll likely be submitting a further patch that removes the
> above code in rs6000-logue.c. I thought is safer to only make a small
> change at the same time as moving code around.
Yeah, just keep it then.
Segher
