On 10/13/20 9:37 PM, Tobias Burnus wrote: > This patch avoids putting some more files to /tmp/cc* when > -save-temps has been specified. >
Very nice. > For my testcase, it now generates: > a.lto_wrapper_args > a.offload_args > a.xnvptx-none.args > a.xnvptx-none.gcc_args > a.xamdgcn-amdhsa.gcc_args > a.xamdgcn-amdhsa.gccnative_args I'd prefer it if nvptx had the same suffixes as gcn, that is, gcc_args and gccnative_args. The ".args" is a bit too non-descript for me. Thanks, - Tom > a.xamdgcn-amdhsa.ld_args > > > This patch adds an additional argument to collect-utils.c's > collect_execute (and is wrapper fork_execute) which, if not NULL, > it is used in 'concat (dumppfx, atsuffix, NULL);'. > > This patch adds a suffix to gcc/config/gcn/mkoffload.c, > gcc/config/nvptx/mkoffload.c and gcc/lto-wrapper.c. > > It does not (yet) add a suffix to gcc/collect2.c and > gcc/config/i386/intelmic-mkoffload.c but just passes > NULL; for intelmic it is not a work item as it does > not use '@' files at all. > > Hopefully, there is no file which is written twice > with the same name (or otherwise overridden) and > the files names do make sense. > > OK? > > Tobias > > PS: There is still cceBdzZk.ofldlist (via lto-plugin/lto-plugin.c), > and @/tmp/cc* in calls to lto1 and collect2. And collect2.c > passes NULL also when use_atfile is true. > > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / > Germany > Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, > Alexander Walter
