Hi Richard Thanks for reviewing again. I have updated the patch to v3.
Regards Qian > -----Original Message----- > From: Richard Sandiford <richard.sandif...@arm.com> > Sent: Tuesday, October 13, 2020 4:00 PM > To: Qian, Jianhua/钱 建华 <qia...@cn.fujitsu.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH v2] arm&aarch64: subdivide the type attribute > "alu_shfit_imm" > > Thanks, the new patch looks great. One minor suggestion: > > "Qian, Jianhua" <qia...@cn.fujitsu.com> writes: > > @@ -1106,7 +1125,45 @@ > > mve_move,\ > > mve_store,\ > > mve_load" > > - (const_string "untyped")) > > + (cond [(eq_attr "autodetect_type" "alu_shift_lsr_op2") > > + (const_string "alu_shift_imm_other") > > + (eq_attr "autodetect_type" "alu_shift_asr_op2") > > + (const_string "alu_shift_imm_other") > > This can be combined into: > > + (cond [(eq_attr "autodetect_type" "alu_shift_lsr_op2,alu_shift_asr_op2") > + (const_string "alu_shift_imm_other") > > But I think the patch is good to go as-is. > > Thanks, > Richard >
0001-arm-aarch64-subdivide-the-type-attribute-alu_shfit_i.patch
Description: 0001-arm-aarch64-subdivide-the-type-attribute-alu_shfit_i.patch
