On Sat, Oct 24, 2020 at 03:11:29AM +0300, Ville Voutilainen wrote:
> On Sat, 24 Oct 2020 at 03:07, Marek Polacek <pola...@redhat.com> wrote:
> > > Ha, we have the same thing in is_trivially_xible, so I'll drive-by
> > > change that one as well.
> >
> > Please.  Thanks!
> 
> The tree is also on a separated line in is_trivially_xible and
> is_nothrow_xible, but not
> in is_xible. What do we think about line-whitespace changes mixed with
> 'real' changes?

I like to do such cleanups when they are nearby the code I'm changing.  In this
case, I think it's totally fine (though I know not everybody feels the same
way).  Clearly you wouldn't do cleanups in different source files or 1000 lines
away from where you're making your change.

Marek

Reply via email to