Andrea Corallo <andrea.cora...@arm.com> writes: > Richard Sandiford <richard.sandif...@arm.com> writes: > > [...] > >>> Hi Richard, >>> >>> I had a look a little more closely and just moving the #undefs to the >>> end of the file is not viable as these macros are: defined, undefined, >>> redefined and finally undefined to generate the intrinsic and theier 'q' >>> variants. >>> >>> In the attached patch the pragmas are added around the bfloat intrinsics >>> without moving the code. >>> >>> Other option would be to rename some of these macro so they can be >>> undefed at the end of the file without overlapping. Please let me know >>> if you prefer this way, I'll be happy to rework the patches accordingly. >> >> Yeah, that sounds better (sorry). This file is big enough and hard >> enough to parse without overloaded macro names adding to the fun. >> Generating the vld2q functions from __LD2Q_LANE_FUNC rather than >> __LD2_LANE_FUNC seems more mnemonic as well as solving the undef >> problem. >> >> Thanks, >> Richard > > Hi Richard, > > here the reworked version renaming in place the > __LD*_LANE_FUNC macros and doing the undef at the bottom of the file. > > Regtested and bootstrapped. > > Okay for trunk and 10?
OK for both. Thanks for doing this. Richard
