On 01/13/2012 08:21 PM, Georg-Johann Lay wrote: > I really don't expect anyone to run test suites on any platform or target > supported by GCC. Such an approach is completely useless because of the amount > of time and system resources and I never proposed that. > > But it appears that many of the test that are exposed to all targets are just > dropped at the testsuite without even looking at them with respect to platform > requirements. > > The most prominent of these requirements is sizeof(int) >= 4 because the most > PRs are reported for such platforms. > > Still I think that patches that are applied to test suite should experience > some review. Anything else will just increase annoyance and frustration of > developers that work for platforms that are not in the center of bolide > hardware. > > For many test cases it's already sufficient to cut down constants so that they > fit into 16 bits, and if actually 32-bit variable is needed GCC provides magic > ike __INT32_TYPE__.
I suggest listing these common testcase pitfalls / best practices somewhere, like for example, on a gcc wiki page. It's then easier to point people at the issues. -- Pedro Alves
