(Very very gentle ping, just to make sure it's still on anyone's radar...!)

On Fri, Oct 9, 2020 at 8:39 AM JeanHeyd Meneide <phdoftheho...@gmail.com> wrote:
>
> Hello,
>
> > Typo:  comple-time
> >
> > >2020-10-08  JeanHeyd "ThePhD" Meneide  <phdoftheho...@gmail.com>
> > >
> > >        * gcc/c-family/c-cppbuiltin.c: Add predefined macro
> > >definitions for charsets
> >
> > I think you should put the macro names in braces after the filename and 
> > drop the trailing "for charsets".
>
>      Can do!
>
> >
> > >        * gcc/doc/cpp.texi: Document new predefined macro.
> > >    * gcc/testsuite/c-c++-common/cpp/wide-narrow-predef-macros.c (new):
> >
> > I think you should drop "(new)" above.
> > thanks,
>
>      I saw that in previous changelogs, but I can change it! Fixed up
> the typos, too.
>
> Sincerely,
> JeanHeyd
>
> 2020-10-09  JeanHeyd "ThePhD" Meneide  <phdoftheho...@gmail.com>
>
>         * gcc/c-family/c-cppbuiltin.c: Add predefined
>           {__GNUC_EXECUTION_CHARSET_NAME} and
>           {__GNUC_WIDE_EXECUTION_CHARSET_NAME} macros
>         * gcc/doc/cpp.texi: Document above new predefined macros
>         * gcc/testsuite/c-c++-common/cpp/wide-narrow-predef-macros.c:
>           New test for macro definitions to always exist and be strings
>         * libcpp/include/cpplib.h: Add functions declarations for
>           retrieving charset names
>         * libcpp/directives.c: Add function definitions to retrieve charset
>           names
>         * libcpp/internal.h: Add to/from name preservations

Reply via email to