Hi Richard, > On 4 Nov 2020, at 20:04, Richard Sandiford <richard.sandif...@arm.com> wrote: > > It's a bit concerning that the second register now overlaps > STACK_CLASH_SVE_CFA_REGNUM, but I agree that isn't a problem > in practice, since the two uses are currently mutually-exclusive.
> I think it might be worth having a comment about that, So maybe add: > > ;; Note that the use of these registers is mutually exclusive with the use > ;; of STACK_CLASH_SVE_CFA_REGNUM, which is for -fstack-clash-protection > ;; rather than -fstack-check. > > to the new comment above. Sure. Yes, the two stack checking modes are definitely exclusive. > OK with that change, thanks. Sorry for the long delay in the review. Great :) No pb. Thanks for your feedback! Best Regards, Olivier
