On Thu, Nov 5, 2020 at 6:10 PM Jojo R <jiejie_r...@c-sky.com> wrote: > gcc/ > * haifa-sched.c (rank_for_schedule): Add bypass_p > cost check in flag_sched_last_insn_heuristic. > > + || (INSN_CODE (DEP_PRO (dep1)) >= 0 && bypass_p (DEP_PRO (dep1)) > + && recog_memoized (DEP_CON (dep1)) >= 0 > + && !dep_cost (dep1))) >
This is using the same idiom at the previous patch. Do the two patches depend on each other? It isn't clear. Since this idiom is used 3 times across the 2 patches, maybe it should be a macro or an inline function. As with the other patch, some explanation would be nice, and some testing on multiple targets too. Jim
