On Fri, Nov 06, 2020 at 02:23:10PM -0500, Jason Merrill via Gcc-patches wrote: > On 11/6/20 2:06 PM, Marek Polacek wrote: > > Following Joseph's change for C to allow duplicate C2x standard attributes > > <https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557272.html>, > > this patch does a similar thing for C++. This is DR 1914, to be resolved by > > <wg21.link/p2156>, which is not part of the standard yet, but has a wide > > support so look like a shoo-in. Some duplications still produce warnings; > > I didn't change that because a warning might be desirable. > > What's the rationale for warning about some and not others?
I don't have any. Joseph's patch removed the error for a duplicated 'fallthrough' attribute, but the warning remained so I left it as-is too. So either we just downgrade the error to a warning, or remove the remaining warnings too. I think I slightly prefer the former; with perhaps a small tweak not to warn when the duplicated attribute comes from a macro expansion. Marek
