On Sat, 7 Nov 2020 at 00:59, Jeff Law <l...@redhat.com> wrote: > > > On 9/18/20 6:33 AM, Christophe Lyon wrote: > > On Thu, 17 Sep 2020 at 23:33, Jeff Law <l...@redhat.com> wrote: > >> > >> On 9/14/20 3:29 AM, Christophe Lyon via Gcc-patches wrote: > >>> Initializing orig_err avoids a warning: "may be used uninitialized". > >>> > >>> 2020-09-14 Torbjörn SVENSSON <torbjorn.svens...@st.com> > >>> Christophe Lyon <christophe.l...@linaro.org> > >>> > >>> libiberty/ > >>> * pex-win32 (pex_win32_exec_child): Initialize orig_err. > >> Rather than just blindly initializing orig_err, we'd actually prefer to > >> have a compilable testcase and analyze why we're getting the warning. A > >> false positive -Wuninitialized warning is often a missed optimization > >> under the hood. > >> > > OK, I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97108 > > after checking the problem is still present with trunk and not only > > with the old gcc version we have in our builders. > > Thanks. I've put an initial analysis in there. I think it's pointing > at a failing in both the traditional threader as well as the backwards > threader. The backwards threader is probably the place to fix it in the > long term. > > > In the immediate term, go ahead with the trivial initialization so that > it doesn't show up in your builds. We'll track the threader issue via > the BZ. >
Thanks, pushed as r11-4828. > > Thanks, > > jeff >
