On Mon, 2020-11-09 at 10:38 -0500, Patrick Palka wrote: > This speeds up handle_pragma_diagnostic by avoiding computing a > spelling > suggestion for an unrecognized option inside a #pragma directive when > -Wpragmas warnings are being suppressed. > > In the range-v3 library, which contains many instances of > > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wpragmas" > #pragma GCC diagnostic ignored "-Wfoo" > ... > #pragma GCC diagnostic pop > > compile time is reduced by 33% in some of its tests. > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK > for > trunk?
Looks good to me. Dave
