On 11/17/20 10:31 PM, will schmidt wrote: > On Fri, 2020-11-13 at 16:04 -0600, Pat Haugen via Gcc-patches wrote: >> +(define_automaton "power10dsp,power10issue,power10div") >> + >> +; Decode/dispatch slots >> +(define_cpu_unit "du0_power10,du1_power10,du2_power10,du3_power10, >> + du4_power10,du5_power10,du6_power10,du7_power10" "power10dsp") >> + >> +; Four execution units >> +(define_cpu_unit "exu0_power10,exu1_power10,exu2_power10,exu3_power10" >> + "power10issue") >> +; Two load units and two store units >> +(define_cpu_unit "lu0_power10,lu1_power10" "power10issue") >> +(define_cpu_unit "stu0_power10,stu1_power10" "power10issue") >> +; Create false units for use by non-pipelined div/sqrt >> +(define_cpu_unit "fx_div0_power10,fx_div1_power10" "power10div") >> +(define_cpu_unit "fp_div0_power10,fp_div1_power10,fp_div2_power10, >> + fp_div3_power10" "power10div") > > The spacing catches my eye, I'd want to add spaces around those commas, > etc. But.. this appears to be consistent with behavior > as seen in the > existing power9.md ; power9.md ; etc. > So it's either this way per necessity, or this way per history. > Either way, no change requested here given that precedence. > (If this and > the older stuff also needs to be cosmetically tweaked, that can be > handled later on..)
Yeah, just historical. >> +; Load Unit >> +(define_insn_reservation "power10-load" 4 >> + (and (eq_attr "type" "load") >> + (eq_attr "update" "no") >> + (eq_attr "size" "!128") >> + (eq_attr "prefixed" "no") >> + (eq_attr "cpu" "power10")) >> + "DU_any_power10,LU_power10") >> + >> +(define_insn_reservation "power10-prefixed-load" 4 >> + (and (eq_attr "type" "load") >> + (eq_attr "update" "no") >> + (eq_attr "size" "!128") >> + (eq_attr "prefixed" "!no") > > I'm sure there is reason, but remind me.. "!no" versus "yes" ? >From my prior patch, the prefixed attribute can now have values no/yes/always, >so '!no' means 'yes' || 'always'. >> + >> +; DFP >> +; Use the minimum 12 cycle latency for all insns, even though some are more > > ".. for all DFP insns" > Since you specify this is a minimum, can prob drop "even though some > are more". ok
