> [AMD Public Use] > > > As per https://gcc.gnu.org/codingconventions.html#ChangeLogs > > --Snip-- > ChangeLogs > ChangeLog entries are part of git commit messages and are automatically put > into a corresponding ChangeLog file. > --Snip-- > > This means Changelog files will be updated automatically? I did not do > anything to Change log files while pushing. > The Change log contents are part of my commit message.
Yes, ChageLog files are now autogenerated and commit messages get some sanity checking at git push time, so if it got accepted it is probably all fine :) Honza > > Regards, > Venkat. > > > -----Original Message----- > > From: Gcc-patches <gcc-patches-boun...@gcc.gnu.org> On Behalf Of > > Kumar, Venkataramanan via Gcc-patches > > Sent: Saturday, December 5, 2020 1:09 PM > > To: Jan Hubicka <hubi...@ucw.cz>; Uros Bizjak <ubiz...@gmail.com> > > Cc: gcc-patches@gcc.gnu.org > > Subject: RE: [PATCH] [X86_64]: Enable support for next generation AMD > > Zen3 CPU > > > > [CAUTION: External Email] > > > > [AMD Public Use] > > > > Hi Honza, > > > > > -----Original Message----- > > > From: Jan Hubicka <hubi...@ucw.cz> > > > Sent: Saturday, December 5, 2020 1:06 AM > > > To: Uros Bizjak <ubiz...@gmail.com> > > > Cc: Kumar, Venkataramanan <venkataramanan.ku...@amd.com>; gcc- > > > patc...@gcc.gnu.org > > > Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD > > > Zen3 CPU > > > > > > [CAUTION: External Email] > > > > > > > On Fri, Dec 4, 2020 at 6:50 PM Kumar, Venkataramanan > > > > <venkataramanan.ku...@amd.com> wrote: > > > > > > > > > > [AMD Public Use] > > > > > > > > > > Hi Uros > > > > > > > > > > > -----Original Message----- > > > > > > From: Uros Bizjak <ubiz...@gmail.com> > > > > > > Sent: Friday, December 4, 2020 2:30 PM > > > > > > To: Kumar, Venkataramanan <venkataramanan.ku...@amd.com> > > > > > > Cc: gcc-patches@gcc.gnu.org; Jan Hubicka (hubi...@ucw.cz) > > > > > > <hubi...@ucw.cz> > > > > > > Subject: Re: [PATCH] [X86_64]: Enable support for next > > > > > > generation AMD > > > > > > Zen3 CPU > > > > > > > > > > > > [CAUTION: External Email] > > > > > > > > > > > > On Thu, Dec 3, 2020 at 4:29 PM Kumar, Venkataramanan > > > > > > <venkataramanan.ku...@amd.com> wrote: > > > > > > > > > > > > > > [AMD Public Use] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Maintainers, > > > > > > > > > > > > > > > > > > > > > > > > > > > > PFA, the patch that enables support for the next generation > > > > > > > AMD > > > > > > > Zen3 > > > > > > CPU via -march=znver3. > > > > > > > > > > > > > > This is a very basic enablement patch. As of now the cost, > > > > > > > tuning and > > > > > > scheduler changes are kept same as znver2. > > > > > > > > > > > > > > Further changes to the cost and tunings will be done later. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Ok for trunk ? > > > > > > > > > > > > Please also add a new target to multiversioning and > > > > > > corresponding testcases. As an example, how this is done > > > > > > nowadays, please see a submission for a different target at [1]. > > > > > > > > > > > > BTW: It looks that multiversioning testcases lack AMD targets. > > > > > > Can you please add a testcase similar to > > > > > > testsuite/g++.target/i386/mv16.C and also add AMD targets to > > > testsuite/gcc.target/i386/funcspec-56.inc. > > > > > > (this can be done in a follow-up patch). > > > > > > > > > > > > [1] > > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > > > > gcc > > > > > > .gnu.org%2Fpipermail%2Fgcc-patches%2F2020- > > > > > > > > > July%2F549699.html&data=04%7C01%7CVenkataramanan.Kumar%40 > > > > > > > > > amd.com%7Cb53d6be6a0d6439396ae08d8983308e9%7C3dd8961fe4884e > > > > > > > > > 608e11a82d994e183d%7C0%7C0%7C637426692241855598%7CUnknown > > > > > > > > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > > > > > > > > > WwiLCJXVCI6Mn0%3D%7C1000&sdata=VAPPvfzv%2FMCRiXSn2eBNn > > > > > > 7bVIReoEHLkAtFgV%2BTFR4I%3D&reserved=0 > > > > > > > > > > > > > > > > Please find attached the version 2 patch. > > > > > > > > > > I have made additional changes as suggested by you. > > > > > 1. Added the AMD Zen targets to funcspec-56.inc file in the tests. > > > > > 2. To covers multiversioning added a new test with some set of > > > > > AMD > > > targets detected by builtin_cpus similar to mv16.C. > > > > > > > > > > is ok for trunk ? > > > > > > > > LGTM (I didn't review scheduling changes in detail). > > > > > > I checked the scheudling changes and they are OK. So the patch is OK > > > overall. > > > > > > Even with respect to Jason's point on possibly regressing primary > > > target (breaking -march=native on zen3 machine counts as a > > > regression), the risks here are low. There is nothing really controveral > > > in the > > patch. > > > > > > It would be nice to setup the regular benchmarking on zen3 machine, > > > like we do for zen1/2. > > > Honza > > > > Thank you for reviewing the patch. I pushed the patch to the gcc trunk. > > > > Ref: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc. > > gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D3e2ae3ee285a > > 57455d5a23bd352a68c289130186&data=04%7C01%7Cvenkataramanan.k > > umar%40amd.com%7C03e85fcff1fe4d8386b508d898f0cb19%7C3dd8961fe488 > > 4e608e11a82d994e183d%7C0%7C0%7C637427507262548698%7CUnknown%7 > > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > > LCJXVCI6Mn0%3D%7C1000&sdata=TcAN3MO7J5nyIjF7RshCS0n5XfketTz > > Cvw6clctIfAI%3D&reserved=0 > > > > > > > > > > Uros. > > > > Regards, > > Venkat.
