On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin <li...@linux.ibm.com> wrote: > > on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor <i...@golang.org> wrote: > >> > >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor <i...@golang.org> wrote: > >>> > >>> I'm trying to commit a change that adds a bunch of new files to > >>> gcc/testsuite/go.test/test. It's being rejected because the hook > >>> can't deduce a ChangeLog file. But this directory has no ChangeLog > >>> files. I've committed other changes to this directory without a > >>> ChangeLog entry. > >>> > >>> What is going wrong? What can I do to commit this change? What > >>> information can I provide? > >>> > >>> Thanks. > >>> > >>> Ian > >>> > >>>> git push > >>> Enumerating objects: 854, done. > >>> Counting objects: 100% (854/854), done. > >>> Delta compression using up to 8 threads > >>> Compressing objects: 100% (824/824), done. > >>> Writing objects: 100% (847/847), 266.10 KiB | 2.25 MiB/s, done. > >>> Total 847 (delta 167), reused 3 (delta 0), pack-reused 0 > >>> remote: Resolving deltas: 100% (167/167), completed with 4 local objects. > >>> remote: *** The following commit was rejected by your > >>> hooks.commit-extra-checker script (status: 1) > >>> remote: *** commit: b09ac944e04a59af95a5767f6835edad7da4f152 > >>> remote: *** ChangeLog format failed: > >>> remote: *** ERR: could not deduce ChangeLog file > >>> remote: *** > >>> remote: *** Please see: > >>> https://gcc.gnu.org/codingconventions.html#ChangeLogs > >>> remote: *** > >>> remote: error: hook declined to update refs/heads/master > >>> To git+ssh://gcc.gnu.org/git/gcc > >>> ! [remote rejected] master -> master (hook declined) > >>> error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc' > >> > >> One less common change I am trying to make is to delete a file. Could > >> that be the cause of this problem? > >> > >> I'm going to try removing the deleted file from the change. > > > > Nope, still failed, though the message is slightly different. > > > > I'm not sure you have figured out the reason and made the push > successfully. > > The files in gcc/testsuite/go.test/test seems still available to > have their changelog entries. Such as for your recent commit > e38c912700f001ea1c8a32533bedb4c802e38d3f. > > git show e38c912700f001ea1c8a32533bedb4c802e38d3f | contrib/mklog.py > gcc/testsuite/ChangeLog: > > * go.test/test/fixedbugs/bug13343.go: New test. > * go.test/test/fixedbugs/bug19403.go: New test. > * go.test/test/fixedbugs/bug369.dir/main.go: New test. > * go.test/test/fixedbugs/bug483.go: New test. > * go.test/test/fixedbugs/bug484.go: New test. > * go.test/test/fixedbugs/bug485.go: New test. > * go.test/test/fixedbugs/bug486.go: New test. > * go.test/test/fixedbugs/bug490.go: New test. > * go.test/test/fixedbugs/bug491.go: New test. > * go.test/test/fixedbugs/bug495.go: New test. > * go.test/test/fixedbugs/bug498.go: New test. > * go.test/test/fixedbugs/bug510.dir/a.go: New test. > * go.test/test/fixedbugs/bug510.dir/b.go: New test. > * go.test/test/fixedbugs/bug510.go: New test. > > Probably the hook becomes stricter somehow recently and complains the > expected changelog entires missing there.
I have not figured this out. I am going to try to submit smaller sets of files. Perhaps the problem was the size of the change, or perhaps it was some specific file. Ian
