On Mon, Dec 14, 2020 at 05:26:03PM -0600, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Dec 03, 2020 at 10:57:56PM -0500, Michael Meissner wrote:
> > --- a/gcc/testsuite/gcc.target/powerpc/pr70117.c
> > +++ b/gcc/testsuite/gcc.target/powerpc/pr70117.c
> > @@ -1,5 +1,6 @@
> > -/* { dg-do run { target { powerpc*-*-linux* powerpc*-*-darwin*
> > powerpc*-*-aix* rs6000-*-* } } } */
> > -/* { dg-options "-std=c99 -mlong-double-128 -O2" } */
> > +/* { dg-do run } */
> > +/* { dg-require-effective-target ppc_long_double_override_ibm } */
> > +/* { dg-options "-std=c99 -O2 -mlong-double-128 -mabi=ibmlongdouble
> > -Wno-psabi" } */
>
>
> So we probably really want some add_options_for_ thing, and use that
> everywhere else?
>
>
> Before this patch you did not test for anything printf (or glibc at
> all); why is that suddenly necessary?
It works fine on systems where long double is IBM extended double (hence the
exclusions for darwin, aix, which do not have 128-bit long double). It does
not work on systems where long double is either 64-bit or uses the IEEE 128-bit
representation.
For example, if I build a compiler where long double is 64-bit (i.e. PR 97543),
this test will fail.
In a previous version of the patch you said that it was a problem in that the
test was not run on systems where we have flipped the long double default. So
I added the options to try and force it to run with IBM 128-bit long double.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
