Hi Ian,

> I've committed a patch to update libgo to the Go 1.16beta1 release.
>
> This patch does not include support for the new //go:embed directive
> that will be available in Go 1.16.1 (https://golang.org/issue/41191)
> Support for that requires compiler changes, which will come later.
>
> As usual with these big updates, I have not included the complete
> changes in this e-mail message, only changes that are gccgo-specific.
>
> Testing this requires some changes to gotools.
>
> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
> to mainline.

this broke Solaris bootstrap:

* On i386-pc-solaris2.11:

/vol/gcc/src/hg/master/local/libgo/go/runtime/os_gccgo.go:43:12: error: 
reference to undefined name 'startupRandomData'
   43 |         if startupRandomData != nil {
      |            ^
/vol/gcc/src/hg/master/local/libgo/go/runtime/os_gccgo.go:44:30: error: 
reference to undefined name 'startupRandomData'
   44 |                 n := copy(r, startupRandomData)
      |                              ^

  startupRandomData is only defined in go/runtime/os_linux.go and relies
  on AT_RANDOM in the aux vector which is Linux-only AFAICT.  For the
  moment, I've just commented that part of the code since it tries
  /dev/urandom next.

  One could also use getentropy instead.

* sparc-sun-solaris2.11 is worse:

/vol/gcc/src/hg/master/local/libgo/go/internal/cpu/cpu.go:123:9: error: 
reference to undefined name 'doinit'
  123 |         doinit()
      |         ^

/vol/gcc/src/hg/master/local/libgo/go/golang.org/x/sys/cpu/cpu.go:199:9: error: 
reference to undefined name ‘archInit’
  199 |         archInit()
      |         ^
/vol/gcc/src/hg/master/local/libgo/go/golang.org/x/sys/cpu/cpu.go:200:9: error: 
reference to undefined name ‘initOptions’
  200 |         initOptions()
      |         ^

  I've used dummy implementations to get along for now.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to