On Mon, 4 Jan 2021, Bernd Edlinger wrote: > Hi, > > > currently there is a problem when debugging a virtual thunk. That is > a decl with DECL_IGNORED_P. Currently the line information displayed > in gdb is completely bogus, thus the last line of whatever function > is immediately before the PC of the thunk.
But isn't this a consumer issue then? If there is no line info for a PC range then gdb shouldn't display any. > This patch improves the debug experience at least a bit by emitting > at the line number information where the thunk has been defined. > I do not dare to touch anything but dwarf2 debug info, therefore > the patch is a bit awkward. There's more DECL_IGNORED_P decls (like functions emitted by profile instrumentation), which do not have any source correspondence. So IMHO the fix should be to make a more nuanced DECL_IGNORED_P for thunks if it is really necessary to emit debug info for them. For example by making them DECL_ARTIFICIAL only (not sure why we end up with them DECL_IGNORED_P - there might be a reason). Richard. > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? > > > Thanks > Bernd. > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
