Hi David, Alright, I'll see what I can do. Would "Skip if target = aix" be ok, especially for the few that I have absolutely no idea why they are failing ?
Clément ________________________________ From: David Edelsohn <dje....@gmail.com> Sent: Monday, January 11, 2021 4:03 PM To: CHIGOT, CLEMENT <clement.chi...@atos.net> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org> Subject: Re: [PATCH] libstdc++: implement locale support for AIX Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. Hi, Clement The patch is local to libstdc++ AIX support, so I believe that I can approve it. libstdc++ loads the gcc testsuite target-supports.exp extensions. The patch needs to update the libstdc++ testcases to require wchar32 or utf-8 as appropriate to avoid the failures. Thanks, David On Mon, Jan 11, 2021 at 4:14 AM CHIGOT, CLEMENT <clement.chi...@atos.net> wrote: > > Hi everyone, > > This patch adds a partial locale support in libstdc++ > for AIX. > The message_members part isn't yet implemented. > > The tests have been launched in AIX7.2 and AIX7.1. > There are a few new tests failing (~20), but most of them > weren't launched before and they don't seem too much > related to locale itself. Some are failing in 32bit because > wchar_t is 16bit on AIX. Some others are failing because > of some slightly AIX differences. > > Please apply for me if approved. > If possible, could it be backported as is in gcc-10, gcc-9 > and maybe gcc-8 branch ? > For gcc-8 branch, there is a few changes to be made in > check_v3_target_namedlocale where the indentation isn't > the same, and the configure needs to be regenerated too. > I've already made the patch if needed. > > Clément Chigot > ATOS Bull SAS > 1 rue de Provence - 38432 Échirolles - France >
