On Thu, Jan 28, 2021 at 01:58:26PM -0600, Peter Bergner wrote: > On 1/28/21 1:47 PM, Segher Boessenkool wrote: > > On Thu, Jan 28, 2021 at 02:30:56PM -0500, Michael Meissner wrote: > >> The second patch I want you to review is: > > > > "This patch replaces the following three patches:" > > > > Please send a patch that modifies *current* code, and that is *tested* > > with that. With a good explanation, and a commit message for *that* > > patch (not for other, older patches). > > Isn't the email Mike linked to which was submitted yesterday exactly this?
It says it is not. That is where I stopped reading. > Admittedly, it doesn't have a "commit message header", but it does seem to > be against current code and he did say he tested it and there is some > explanation given, just not in a commit message form. Is it just a nice > commit message you're looking for now? Just like for any other patch, I need to know what it *is*, why this is an improvement, and all that. The usual. And not in ten pages but in a few sentences. After such an introduction you can go into detail where that is warranted, for example necessary to understand the patch, but you do not explain the history of the world in a commit message. I do not have the bandwidth to spend hours on this again today trying to figure out what this patch is. Segher
