On Mon, Jan 25, 2021 at 04:37:21PM -0600, Segher Boessenkool wrote: > I still do not see what this improves, I only see possible obvious > regressions :-(
You asked me to break the patch series into small pieces, for ease of review and to separate tidies from functional changes. Well OK, fair enough. This is one of the tidies. The idea being to make rs6000_rtx_costs a little more self-consistent, to not have someone look at this code in the future and wonder why AND was treated differently to other operations. The only part of this patch that I can imagine you see as a possible regression is the "Don't avoid recursion on const_int shift count" part. That is there only because you wanted it that way in new code. I think you said something about premature optimisation when I made the new code special case const_int and reg to stop recursion, like AND. So for consistency I made the change in old code too. -- Alan Modra Australia Development Lab, IBM
