> From: Bernd Edlinger <bernd.edlin...@hotmail.de>
> Date: Tue, 16 Feb 2021 08:35:04 +0100
> Oops,
>
> thanks for fixing this problem.
>
> To my excuse I would like to note,
> that the script error does not happen on x86_64-pc-linux-gnu,
> probably it would only happen when a file is left over.
Sorry but that just sounds to me like bad coverage when
testing this patch.
AFAIU unfortunately errors including tcl syntax errors do
not cause any difference in error return codes for "make
check" (compared to the usual unclean run; with some errors).
> Since usually this is never executed because $outs is empty:
> ...
> Can you say which target was this, where you found this bug?
A simulator target: cris-elf:
'make check RUNTESTFLAGS=--target_board=cris-sim'
> Which file was in $outs?
I added:
--- outputs.exp~ 2021-01-11 17:44:41.000000000 +0100
+++ outputs.exp 2021-02-16 11:41:32.130512321 +0100
@@ -187,6 +187,7 @@ proc outest { test sources opts dirs out
}
set outb {}
+ send_log "for test <$test>, outs is <$outs>\n"
foreach f $outs {
file delete $f
# collect2 may create <execname>.cdtor* files in -save-temps link tests,
and ran "make check-gcc-c 'RUNTESTFLAGS=--target_board=cris-sim outputs.exp'"
which resulted in this in gcc.log:
...
PASS: outputs exe savetmp namedb: outputs-outputs-0.i
PASS: outputs exe savetmp namedb: outputs-outputs-0.s
PASS: outputs exe savetmp namedb: outputs-outputs-0.o
PASS: outputs exe savetmp namedb: outputs.args.0
PASS: outputs exe savetmp namedb: outputs.ld1_args
PASS: outputs exe savetmp namedb: outputs.exe
for test <outputs exe savetmp namedb>, outs is <outputs.args.1>
ERROR: (DejaGnu) proc "is_target hppa*-*-hpux*" does not exist.
...
> I am also a bit surprised that a script error in one test aborts
> the whole gcc.target tests. How can that be?
TBH, I'm not really surprised by dejagnu exiting due to an
undefined function/proc, but maybe for penance you can look
into this and wrap key points (like each .exp file) into
try-clauses? ;-]
brgds, H-P
