On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote: > On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva <ol...@adacore.com> wrote: > > > > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2 > > tests. Tested on x86_64-linux-gnu, and on the affected platform. Ok to > > install? > > I'm sort of surprised that sqrt instruction would be available for the > target but not enabled by default. Is this really the method that > customers would use? It seems that it might be more appropriate to > xfail or skip the test for PPC64 VxWorks.
You should essentially never use -mpowerpc-gpopt, but instead use a -mcpu= that has it. You also of course whould not do that in run tests if the cpu does not support those insns. But, Alex, you say this avoids an ICE? You shouldn't avoid the ICE in that testcase then -- instead, fix it! (Or report it). Segher
