On Sat, Feb 27, 2021 at 02:59:03PM +0000, Iain Sandoe wrote: > This test fails everywhere on Darwin, which does not have support for symbol > aliases. Add a dg-require-alias to UNSUPPORT it. > > Ordinarily, I would have considered adding the dg-require as ‘obvious’ but I > see > that you already handled one case specifically (so wonder if there is some > reason > not to use this).
The testcase needs alias support both on the host (for which dg-require-alias is the right thing) and on the offloading target side (nvptx in this case). > OK for master? Yes. > libgomp/ChangeLog: > > * testsuite/libgomp.c-c++-common/pr96390.c: Require alias > support from the target. > --- > libgomp/testsuite/libgomp.c-c++-common/pr96390.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libgomp/testsuite/libgomp.c-c++-common/pr96390.c > b/libgomp/testsuite/libgomp.c-c++-common/pr96390.c > index 692bd730069..4fe09cebb5d 100644 > --- a/libgomp/testsuite/libgomp.c-c++-common/pr96390.c > +++ b/libgomp/testsuite/libgomp.c-c++-common/pr96390.c > @@ -1,4 +1,5 @@ > /* { dg-additional-options "-O0 -fdump-tree-omplower" } */ > +/* { dg-require-alias "" } */ > /* { dg-xfail-if "PR 97102/PR 97106 - .alias not (yet) supported for nvptx" > { offload_target_nvptx } } */ > > #ifdef __cplusplus > -- > 2.24.1 > Jakub