Jason Merrill <ja...@redhat.com> wrote:
On 2/26/21 4:36 PM, Iain Sandoe wrote:
Jason Merrill <ja...@redhat.com> wrote:
On 2/24/21 3:06 PM, Iain Sandoe wrote:
So (a) the 'throwing_cleanup' is no longer correct for the ramp and
(b) we do not need to transfer it to the actor which only contains
void returns.
OK, but I wonder if there are other things that should also be reset.
That would be believable but, absent problem reports, have you any advice
on how/what to audit?
Looking at language_function, I guess it would make sense to clear
returns_abnormally and infinite_loop{,s}, maybe bindings.
thanks, I’ll take a look.
Since you're completely replacing the function body, almost none of the
information we previously recorded about it in cfun is accurate.
Yes, and maybe no longer accurate about the body when transferred to the
actor function [like the throwing_cleanup] (but it’s worth considering the
other cases anyway).
But it may be harmless.
I’d be inclined to null stuff out if it’s definitively unneeded - so will
check some more.
thanks
Iain
