Hi! On Wed, Mar 03, 2021 at 06:07:29PM -0300, Alexandre Oliva wrote: > On Mar 3, 2021, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > It's skipping the test, as the change you propose, that reduces testing > surface, when testing only a configuration that ends up skipping it.
Not at all. There are very many more configurations that have floating point disabled then that there are configurations with FP enabled but without square root insns (almost no one targets G4 anymore, it is over twenty years old). In any case, the existing code did not do two necessary checks. I corrected that. > > This is fixed trivially by the PR99352 patch as far as I can see. > > If your patch also deals with the ICE that appears with the options > named in PR99372, great. It does afaics. Please check? Segher
