On Mar 10, 2021, Joseph Myers <jos...@codesourcery.com> wrote: > In my view, such an XFAIL (for a GCC bug as opposed to an environmental > issue) should have a comment pointing to a corresponding open bug in GCC > Bugzilla. In this case, that's bug 58684.
Thanks, yeah, that's valuable information to add. So far, I added a link to the PR in the ChangeLog entry, and noticed and fixed a typo in the filename there. I kind of like the notion of adding a comment to the test itself, but I wasn't sure that's what you meant. I kind of like it because I'd have appreciated if the other tests, that I had identified, had comments linking back to the PR. OTOH, I realize if I had searched the ChangeLog or their commit history, I'd have found my way to the PR. Instead, I just realized that that was the way ppc was expected to behave, and quickly double-checked the code to make sure there was no implemented alternative in hiding, entirely missing the PR. xfail fetestexcept test - ppc always uses fcmpu From: Alexandre Oliva <ol...@adacore.com> gcc.dg/torture/pr91323.c tests that a compare with NaNf doesn't set an exception using builtin compare intrinsics, and that it does when using regular compare operators. That doesn't seem to be expected to work on powerpc targets. It fails on GNU/Linux, it's marked to be skipped on AIX, and a similar test, gcc.dg/torture/pr93133.c, has the execution test xfailed for all of powerpc*-*-*. In this test, the functions that use intrinsics for the compare end up with the same code as the one that uses compare operators, using fcmpu, a floating compare that, unlike fcmpo, does not set the invalid operand exception for quiet NaN. I couldn't find any evidence that the rs6000 backend ever outputs fcmpo. Therefore, I'm adding the same execution xfail marker to this test. for gcc/testsuite/ChangeLog PR target/58684 * gcc.dg/torture/pr91323.c: Expect execution fail on powerpc*-*-*. --- gcc/testsuite/gcc.dg/torture/pr91323.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/torture/pr91323.c b/gcc/testsuite/gcc.dg/torture/pr91323.c index 1411fcaa3966c..f97dcc12cac9d 100644 --- a/gcc/testsuite/gcc.dg/torture/pr91323.c +++ b/gcc/testsuite/gcc.dg/torture/pr91323.c @@ -1,4 +1,4 @@ -/* { dg-do run } */ +/* { dg-do run { xfail powerpc*-*-* } } */ /* { dg-add-options ieee } */ /* { dg-require-effective-target fenv_exceptions } */ /* { dg-skip-if "fenv" { powerpc-ibm-aix* } } */ -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar