On Tue, 2021-03-23 at 12:48 +0000, Richard Sandiford wrote:
> Ilya Leoshkevich <i...@linux.ibm.com> writes:
> > +inline use_info *
> > +set_info::single_nondebug_use () const
> > +{
> > +  use_info *nondebug_insn = single_nondebug_insn_use ();
> > +  if (nondebug_insn)
> > +    return has_phi_uses () ? nullptr : nondebug_insn;
> > +  use_info *phi = single_phi_use ();
> > +  if (phi)
> > +    return has_nondebug_insn_uses() ? nullptr : phi;
> > +  return nullptr;
> 
> Very minor, but I think this is simpler as:
> 
>   if (!has_phi_uses ())
>     return single_nondebug_insn_use ();
>   if (!has_nondebug_insn_uses ())
>     return single_phi_use ();
>   return nullptr;
> 
> OK with that change (or without if you prefer the original).
> Thanks for the fix and for your patience. :-)
> 
> Richard

Retested with the change above and pushed as:

https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b61461ac7f9bdd0e98145be79423d19b933afaa0

Thanks for all the suggestions!

Best regards,
Ilya

Reply via email to