On Tue, 4 May 2021 at 07:30, Alexandre Oliva <ol...@adacore.com> wrote: > > On May 3, 2021, Richard Biener <richard.guent...@gmail.com> wrote: > > > On Fri, Apr 30, 2021 at 4:42 PM Jeff Law <jeffreya...@gmail.com> wrote: > >> > >> > >> On 4/28/2021 10:26 PM, Alexandre Oliva wrote: > >> > On Feb 22, 2021, Richard Biener <richard.guent...@gmail.com> wrote: > >> > > >> >> On Fri, Feb 19, 2021 at 9:08 AM Alexandre Oliva <ol...@adacore.com> > >> >> wrote: > >> >>> Here's an improved version of the patch. Regstrapped on > >> >>> x86_64-linux-gnu, with and without a patchlet that moved multi-pieces > >> >>> ahead of setmem, and also tested with riscv32-elf. > >> >>> > >> >>> Is it ok to install? Or should it wait for stage1? > >> >> It generally looks OK but I'd wait for stage1. > >> > 'k, I've retested the patch now, and it's still working as expected. > >> > >> Then I'd go forward with it at this point. > > > Yes, it looks good to me as well. > > Thanks, I've put it in. Hi, This caused the following build error: ../../gcc/gcc/builtins.c:6750:18: error: invalid conversion from ‘rtx_def* (*)(void*, void*, long int, scalar_int_mode)’ to rtx_def* (*)(void*, long int, scalar_int_mode)’ [-fpermissive] 6750 | constfun = builtin_memset_gen_str;
It looks like constfun's prototype had a typo with missing 2nd param for void *. I committed the fix as obvious in the following commit: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=5fbe6a8e73b52c6ebc28b9111456226c1cda6472 Thanks, Prathamesh > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about <https://stallmansupport.org>
