On Thu, May 20, 2021 at 11:49:03AM +0100, Tamar Christina wrote:
> libsanitizer: Guard cyclades inclusion in sanitizer
> 
> The Linux kernel has removed the interface to cyclades from
> the latest kernel headers[1] due to them being orphaned for the
> past 13 years.
> 
> libsanitizer uses this header when compiling against glibc, but
> glibcs itself doesn't seem to have any references to cyclades.
> 
> Further more it seems that the driver is broken in the kernel and
> the firmware doesn't seem to be available anymore.
> 
> As such since this is breaking the build of libsanitizer (and so the
> GCC bootstrap[2]) I propose to remove this.
> 
> [1] https://lkml.org/lkml/2021/3/2/153
> [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100379
> 
> (cherry picked from commit f7c5351552387bd43f6ca3631016d7f0dfe0f135)
> 
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
> 
> Ok for master?
> 
> Thanks,
> Tamar
> 
> libsanitizer/ChangeLog:
> 
>       PR sanitizer/100379
>       * sanitizer_common/sanitizer_common_interceptors_ioctl.inc: Remove 
> cyclades.
>       * sanitizer_common/sanitizer_platform_limits_posix.cpp: Likewise.
>       * sanitizer_common/sanitizer_platform_limits_posix.h: Likewise.

The *.inc line is too long.  And furthermore it should read:
        PR sanitizer/100379
        * sanitizer_common/sanitizer_common_interceptors_ioctl.inc: Cherry-pick
        llvm-project revision f7c5351552387bd43f6ca3631016d7f0dfe0f135.
        * sanitizer_common/sanitizer_platform_limits_posix.cpp: Likewise.
        * sanitizer_common/sanitizer_platform_limits_posix.h: Likewise.

Ok for trunk and release branches with that change.
Thanks.

        Jakub

Reply via email to