On Thu, May 20, 2021 at 02:29:02PM -0500, will schmidt wrote: > On Tue, 2021-05-18 at 16:36 -0400, Michael Meissner wrote: > > [PATCH] Allow __ibm128 on older PowerPC systems. > > > > Hi, > > > > On January 8th, 2018, I added code to ibm-ldouble.c to use the built-in > > function __builtin_pack_ibm128 if long double is IEEE 128-bit and continue > > to > > use __builtin_pack_longdouble if long double is IBM extended double. This > > code > > was needed because __builtin_pack_ibm128 is not available unless the > > __ibm128 > > keyword is availabe. In the current code, __ibm128 is only enabled if we > > have > > support for both IBM and IEEE 128-bit long double. > > "available." > > May be worth re-sifting the description to drop the history not > directly applicable to what this patch is doing.
When I commit the patch, I try to eliminate the history section. But for active patches, I hope that it helps to state what is different from the previous patches. > > gcc/ > > 2021-05-18 Michael Meissner <meiss...@linux.ibm.com> > > > > * config/rs6000/rs6000-builtin.def (BU_IBM128_2): Rename > > RS6000_BTM_IBM128 from RS6000_BTM_FLOAT128. > > > * config/rs6000/rs6000-call.c (rs6000_invalid_builtin): Update > > error message for __ibm128 built-in functions. > > (rs6000_init_builtins): Create the __ibm128 keyword on older > > systems where long double uses the IBM extended double format, > > even if they don't support IEEE 128-bit floating point. > > Could drop 'older', ok. Well yes, but the reality is all of the server systems that support VSX (and hence IEEE 128-bit) are newer than the systems that don't (power6, power5, etc.). -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
