Hi!
On Mon, Apr 26, 2021 at 09:35:58AM -0700, Carl Love wrote:
> This patch fixes the order of the argument in the vec_rlmi and
> vec_rlnm builtins. The patch also adds a new test cases to verify
> the fix.
>
> The patch has been tested on
> powerpc64-linux instead (Power 8 BE)
> powerpc64-linux instead (Power 9 LE)
> powerpc64-linux instead (Power 10 LE)
Those last two are powerpc64le-linux, right?
> gcc/testsuite/
> gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c:
> New runnable test case.
> gcc.target/powerpc/vec-rlmi-rlnm.c: Update scan assembler times
> for xxlor instruction.
These need a leading *, as Will pointed out.
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/check-builtin-vec_rlnm-runnable.c
> @@ -0,0 +1,231 @@
> +/* { dg-do run } */
> +/* { dg-require-effective-target powerpc_p9vector_ok } */
> +/* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */
It's a run test, so it needs p9vector_hw (no powerpc_ prefix on that
one).
> --- a/gcc/testsuite/gcc.target/powerpc/vec-rlmi-rlnm.c
> +++ b/gcc/testsuite/gcc.target/powerpc/vec-rlmi-rlnm.c
> @@ -62,6 +62,6 @@ rlnm_test_2 (vector unsigned long long x, vector unsigned
> long long y,
> -/* { dg-final { scan-assembler-times "xxlor" 3 } } */
> +/* { dg-final { scan-assembler-times "xxlor" 5 } } */
This was expected, right?
Okay for trunk, and backports after a while. Thanks!
Segher
