On Mon, May 31, 2021 at 10:14:34AM +0200, Christophe Lyon wrote:
> > Something I've missed during the review but it shows up during testing:
> >
> > > diff --git a/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> > > b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> > > new file mode 100644
> > > index 00000000000..cad36aaf8b7
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> > > @@ -0,0 +1,45 @@
> > > +! { dg-do run }
> >
> > gcc/testsuite/*/gomp/ shouldn't have dg-do run tests, either
> > it is meant to be a runtime test and then it should be moved to
> > libgomp/testsuite/libgomp.fortran/ , or it should be changed to
> > dg-do compile.
> >
>
> In addition, on arm/aarch64 at least, I can see the test failing to compile:
> gfortran: fatal error: cannot read spec file 'libgomp.spec': No such
> file or directory
That is the same thing, libgomp.spec is also needed during linking with
-fopenmp, and if it would be found, libgomp.so wouldn't.
While e.g. g++.dg/ testsuite has code to find and add the libstdc++ headers
and includes also to g++.dg tests, for libgomp we have that code only in
the libgomp testsuite.
Jakub
