On Wed, Jun 2, 2021 at 2:05 PM Eric Botcazou <botca...@adacore.com> wrote: > > Hi, > > as explained in the audit trail, the return part has a major performance > impact in Ada where variable-sized types are first-class citizens, but it > turns out that it is not exercized in the testsuite yet. > > Tested on x86-64/Linux, OK for mainline and 11 branch?
Not sure whether we know VLA results are always returned by reference? In particular does this mean we'll never see a WITH_SIZE_EXPR on the LHS of a call? You might have noticed I've done WITH_SIZE_EXPR "enhancements" recently on trunk. As for the patch we indeed didn't have a testcase covering the return case so it should be safe to revert the return part. I still wonder about the WITH_SIZE_EXPR here ;) Richard. > > 2021-06-02 Eric Botcazou <ebotca...@adacore.com> > > PR ipa/99122 > * tree-inline.c (inline_forbidden_p): Remove test on return type. > > > 2021-06-02 Eric Botcazou <ebotca...@adacore.com> > > * gnat.dg/inline22.adb: New test. > > -- > Eric Botcazou
